Re-add PR #459: ExecuteDFS (generic depth first search)#505
Closed
wilfwilson wants to merge 1 commit intomainfrom
Closed
Re-add PR #459: ExecuteDFS (generic depth first search)#505wilfwilson wants to merge 1 commit intomainfrom
wilfwilson wants to merge 1 commit intomainfrom
Conversation
wilfwilson
added
do not merge
wilfwilson
force-pushed
the
readd-new-dfs
branch
from
d650fea to
c031507
Compare
Collaborator
Author
|
I've rebased this but not done a great job of resolving merge conflicts: since this PR was made, I think the function |
wilfwilson
force-pushed
the
readd-new-dfs
branch
from
c031507 to
e3c3f6d
Compare
Member
|
There's a new much better version by @saffronmciver on my phone and can't find the number of the pr |
Collaborator
Author
|
Ah good to know, so that will supersede whatever is in here? Great! Update: yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #504, in other words, it adds again the code that was in #459.
Since the code in this PR is buggy (see #487), it was removed from the
mainbranch. I do not imagine that this PR itself will ever be merged (at least not as-is), but I have pushed this branch and opened this PR so that we do not lose track of this code.@james-d-mitchell has started PR #499 to try to fix this, which I have taken the liberty of rebasing on top of this branch. When #499 is merged, this PR should then be closed, and the associated branch deleted.